-
Notifications
You must be signed in to change notification settings - Fork 34
Fix passing of non-ASCII characters as command-line arguments #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Overall looks great 👍 It the use of |
Yes, I just chose I could not test it (just the compilation), so it would be great if you could test it on Linux as described here. |
Thanks for the detailed explanation. I will test tomorrow and then move forward with creating a new release. |
Would it be possible to merge this branch ? |
Any feedback ? @jcfr |
This is still a problem - https://discourse.slicer.org/t/patientname-and-rus-language-trouble/28870/9 |
Once continuous integration is fixed, the branch associated with this pull request will be rebased. Related pull requests:
|
I've added a fix that also fixes passing special characters in command-line arguments and fixes the issue of not being able to launch Slicer in a path that contains special character (Slicer/Slicer#8229). |
@lassoan It looks like the mac build timed out. Perhaps this can be tested offline to ensure that the changes recommended are ready for inclusion. |
Runner "macos-12" was removed on 2024.12.03 See https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/ > We are beginning the deprecation process for the macOS 12 runner image, which allows us to balance our fleet capacity ahead of our upcoming macOS 15 launch. This image will be fully retired by the December 3rd, 2024.
Should fix the issues described here: https://discourse.slicer.org/t/slicer-ignoring-command-line-path-with-accents/24569
…Windows Application path and command-line arguments can now contain special characters. Note: console launcher on Windows still has not been fixed. wmain would need to be used instead of main and wide characters should be converted to utf8.
38dc94a
to
2202431
Compare
Various CI fixes are needed here. I pushed updates that resolved the testing on macOS as seen by the successful macos-13 status check. The "macos-12" status check needs to no longer be a required status check as it will no longer get run as macos-12 github runner was removed at the end of 2024. |
FYI: ```
|
@jamesobutler I made some naiave attempts to fix CI, but it will like require someone with passwords to re-create a new docker image. I've isolated the CI failures in : #136 Perhaps we could decouple the "non-ASCII characters" fixes from the "CI failures" |
There seems to be a dependence on https://github.com/jcfr/qt-static-build. Perhaps that project should be moved to commontk or Slicer organizations. |
Should fix the issues described here: https://discourse.slicer.org/t/slicer-ignoring-command-line-path-with-accents/24569